Repository navigation
fix(search-events): Keep issue filters the agent rewrites - #2445
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
A structured errors query still goes through the embedded agent, and its query runs as-is unless it downgrades a filter. The agent has dropped the last character of an issue short ID (issue:PROJ-2B3 -> issue:PROJ-2B), so Sentry rejected the search with "Issue IDs do not exist". validateSearch can't catch this because the validate endpoint skips the errors dataset. Issue IDs are exact identifiers, so when the agent changes or drops an explicit issue: or issue.id: filter, run the caller's structured query. Fixes #2443
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Match issue: and issue.id: filters after an opening parenthesis too, so an agent rewrite inside (issue:A OR issue:B) also falls back to the caller's query.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A structured errors query (for example
issue:PROJ-2B3with explicit fields) still goes through the embedded agent, because errors isn't a trace-item dataset and never qualifies forcanRunWithoutAgent. The agent's query then runs as-is unlessisSemanticFilterDowngradefires, and that check doesn't compare filter values.In two user reports the agent dropped the last character of a valid short ID (
issue:PROJ-2B3→issue:PROJ-2B), so Sentry rejected the search withIssue IDs do not exist.validateSearchpassed because the validate endpoint doesn't check the errors dataset.Issue IDs are exact identifiers, so when the agent changes or drops an explicit
issue:/issue.id:filter from a structured query, this runs the caller's query instead, the same way a semantic filter downgrade already falls back.This touches the same expression as #2139 (restores dropped
timestamp:bounds), so whichever merges second needs a small rebase.Fixes #2443
via automation
evt_905b9c478746fd9deeb853f85ad7441b· Run IDdispatch_6beea850935f9ba32a9ce5724de8c370.--
View Session [Sentry]